Set install and upgrade retries of HelmReleases to -1

[ubergesundheit]

What does this PR do?

• Set spec.install.remediation.retries to -1 from previous 30
• Set spec.upgrade.remediation.retries to -1. This wasn't set at all previously

Any background context you can provide?

This is a follow up to PR #394 for giantswarm/roadmap#3664

• CHANGELOG.md has been updated (if it exists)

[taylorbot]

Hey @ubergesundheit, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#986 in order to test your cluster chart changes on AWS.

[github-actions]

There were differences in the rendered Helm template, please check! ⚠️

Output

=== Differences when rendered with values file helm/cluster/ci/test-cgroupsv1-values.yaml ===

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  ± value change
    - 30
    + -1



=== Differences when rendered with values file helm/cluster/ci/test-required-values.yaml ===

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  ± value change
    - 30
    + -1



=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-and-local-values.yaml ===

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  ± value change
    - 30
    + -1



=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-values.yaml ===

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  ± value change
    - 30
    + -1



=== Differences when rendered with values file helm/cluster/ci/test-zot-only-local-values.yaml ===

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-cilium)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-coredns)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-network-policies)
  ± value change
    - 30
    + -1

/spec  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  + one map entry added:
    upgrade:
      remediation:
        retries: -1

/spec/install/remediation/retries  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/awesome-vertical-pod-autoscaler-crd)
  ± value change
    - 30
    + -1

[Gacko]

Thank you! No need to release this, yet, as it would make it way to clusters when released in the provider specific cluster app and a platform release, only. So we'll take care the next time we do releases. Also there's a breaking change on main which requires a v2.0.0 and cannot be introduced in v29.x.x platform releases.