Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation for gc to cleanup loadbalancers and security groups #593

Merged
merged 2 commits into from
May 7, 2024

Conversation

bdehri
Copy link
Contributor

@bdehri bdehri commented Apr 18, 2024

What this PR does / why we need it

This PR adds an annotation for garbage collector to cleanup load-balancer resources created in the same VPC as the cluster.

Towards https://github.com/giantswarm/adidas/issues/1237

Checklist

  • Updated CHANGELOG.md.

Trigger E2E tests

/run cluster-test-suites

@bdehri bdehri self-assigned this Apr 18, 2024
@bdehri
Copy link
Contributor Author

bdehri commented Apr 18, 2024

/run cluster-test-suites

@bdehri
Copy link
Contributor Author

bdehri commented Apr 18, 2024

/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@tinkerers-ci

This comment has been minimized.

@bdehri bdehri marked this pull request as ready for review April 18, 2024 15:46
@bdehri bdehri requested a review from a team as a code owner April 18, 2024 15:46
@bdehri bdehri changed the title add annotation for gc to cleanup loadbalancers add annotation for gc to cleanup loadbalancers and security groups May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

There were differences in the rendered Helm template, please check! ⚠️

Output
=== Differences when rendered with values file helm/cluster-aws/ci/test-mc-proxy-values.yaml ===

/metadata/annotations  (infrastructure.cluster.x-k8s.io/v1beta2/AWSCluster/org-giantswarm/test-mc-proxy)
  + one map entry added:
    aws.cluster.x-k8s.io/external-resource-tasks-gc: "load-balancer,security-group"
    
  



=== Differences when rendered with values file helm/cluster-aws/ci/test-network-topology-values.yaml ===

/metadata/annotations  (infrastructure.cluster.x-k8s.io/v1beta2/AWSCluster/org-giantswarm/test-wc-minimal)
  + one map entry added:
    aws.cluster.x-k8s.io/external-resource-tasks-gc: "load-balancer,security-group"
    
  



=== Differences when rendered with values file helm/cluster-aws/ci/test-wc-minimal-values.yaml ===

/metadata/annotations  (infrastructure.cluster.x-k8s.io/v1beta2/AWSCluster/org-giantswarm/test-wc-minimal)
  + one map entry added:
    aws.cluster.x-k8s.io/external-resource-tasks-gc: "load-balancer,security-group"
    
  

@bdehri
Copy link
Contributor Author

bdehri commented May 7, 2024

/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@tinkerers-ci
Copy link

tinkerers-ci bot commented May 7, 2024

cluster-test-suites

Run name pr-cluster-aws-593-cluster-test-suites586dx
Commit SHA ad8a023
Result Succeeded ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

@bdehri bdehri merged commit 32d4a4d into main May 7, 2024
11 checks passed
@bdehri bdehri deleted the lbgc branch May 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants