-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure kubelet Shutdown Grace Period #276
Conversation
Skipping CI for Draft Pull Request. |
/test all |
@mnitchev: No jobs can be run with
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from comments
/test create |
What this PR does / why we need it
This PR configures both the
shutdownGracePeriod
andshutdownGracePeriodCriticalPods
. The grace period is set to 5 minutes while the critical pods grace period is set to 1 minute. This means that kubelet will start terminating critical pods (pods with Priority class set tosystem-cluster-critical
orsystem-node-critical
) in the last 1 minute of theshutdownGracePeriod
. This is important since our CNI (cilium) is a critical pod that needs to terminated last.This feature is implemented using systemd Inhibitor Locs. The maximum inhibit delay is controlled by the
InhibitDelayMaxSec
inlogind
. On our AWS nodes the default is set to 30 seconds, so we need to override it. This is why the/lib/systemd/logind.conf.d/zzz-kubelet-graceful-shutdown.conf
is mounted in the nodes (thezzz
prefix is so it always lands as the last evaluated file).Checklist
References
Trigger e2e tests
/test create
/test upgrade
/run cluster-test-suites