Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Giant Swarm image repository for official Kubernetes images #202

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Jan 12, 2023

What this PR does / why we need it

Towards giantswarm/roadmap#1722.

Official Kubernetes images were previously still pulled from upstream repos such as k8s.gcr.io (deprecated) and registry.k8s.io. Private clusters may not want to open access to them, and in general we use our own image hosting (e.g. Docker Hub, Quay) to remain reliable. The switch to Docker Hub requires that clusters have working Docker Hub credentials, or else will soon run into their drastic rate limits for anonymous image pulls.

As prerequisite, I had changed retagger to mirror the needed images (giantswarm/retagger#780). Mind kubernetes/kubeadm#2603 which can make the coredns image mirroring unnecessary in the future.

I successfully tested on golem whether the node rollout works using the new imageRepository value.

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/test create
/test upgrade

@AndiDog AndiDog requested a review from a team January 12, 2023 10:30
@AndiDog AndiDog enabled auto-merge (squash) January 12, 2023 10:42
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 12, 2023

/test create
/test upgrade

Tekton pipeline didn't finish because of the merge commit that came later.

@AndiDog AndiDog merged commit 08e82c8 into master Jan 12, 2023
@AndiDog AndiDog deleted the image-repo branch January 12, 2023 11:23
@tityosbot
Copy link

@AndiDog: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
create 1fe0d29 link /test create
upgrade 1fe0d29 link /test upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@tityosbot
Copy link

@AndiDog: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
create 1fe0d29 link /test create
upgrade 1fe0d29 link /test upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants