Use Giant Swarm image repository for official Kubernetes images #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Towards giantswarm/roadmap#1722.
Official Kubernetes images were previously still pulled from upstream repos such as
k8s.gcr.io
(deprecated) andregistry.k8s.io
. Private clusters may not want to open access to them, and in general we use our own image hosting (e.g. Docker Hub, Quay) to remain reliable. The switch to Docker Hub requires that clusters have working Docker Hub credentials, or else will soon run into their drastic rate limits for anonymous image pulls.As prerequisite, I had changed retagger to mirror the needed images (giantswarm/retagger#780). Mind kubernetes/kubeadm#2603 which can make the
coredns
image mirroring unnecessary in the future.I successfully tested on
golem
whether the node rollout works using the newimageRepository
value.Checklist
Trigger e2e tests
/test create
/test upgrade