Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override image repository because kubeadm of Kubernetes v1.23.15 tries to pull the official image incorrectly #197

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Jan 11, 2023

What this PR does / why we need it

Towards giantswarm/roadmap#1669

While kubeadm is buggy (kubernetes/kubernetes#114978) and tries to download the CoreDNS image despite us skipping that addon (kubernetes/kubeadm#2603), we try to use the new official repository already. This fixes kubeadm join for new Kubernetes versions and therefore avoids stuck node upgrades. CAPI propagates the value of clusterConfiguration.imageRepository before attempting the node upgrade (but doesn't propagate clusterConfiguration.dns.imageRepository so we can't make this a CoreDNS-scoped change).

This would then happen on upgrade:

  • Existing CAPI-managed cluster with Kubernetes < v1.23.15 (older version of cluster-aws)
  • cluster-aws version upgrade changes the KubeadmControlPlane manifest, setting both a higher Kubernetes version and the new image repository at once
  • CAPI propagates the desired image repository value and then starts the rollout (see upgrade logic)

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/test create
/test upgrade

…s to pull the official image incorrectly

While kubeadm is buggy (kubernetes/kubernetes#114978) and tries to download the CoreDNS image despite us skipping that addon (kubernetes/kubeadm#2603), we try to use the new official repository already. This fixes `kubeadm join` for new Kubernetes versions and therefore avoids stuck node upgrades. CAPI propagates this value before attempting the node upgrade.
@AndiDog AndiDog requested a review from a team January 11, 2023 10:42
@AndiDog AndiDog merged commit 602ef1a into master Jan 11, 2023
@AndiDog AndiDog deleted the image-repo branch January 11, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants