Add release manifest to Giant Swarm specific image so cluster-api-provider-aws-app can fetch CRDs from there instead of having to use GitHub releases
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider-aws-app` can fetch CRDs from there instead of having to use GitHub releases
1 task
|
Guess this is fine, based on offline discussion |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#1832
Since we don't use GitHub releases from which we could fetch the relevant file with CRDs (
infrastructure-components.yaml), I thought of simply adding that file to the image. This way, the app repo https://github.com/giantswarm/cluster-api-provider-aws-app can be adapted very easily to get the CRDs from the correct commit of our CAPA fork.This is to avoid mismatches between CRD and controller version.
I have the matching change to
cluster-api-provider-aws-appready, but won't open that PR yet since we're blocked on upgrading CAPA (giantswarm/roadmap#1932).