Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all upstream changes to templates #44

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Added all upstream changes to templates #44

merged 4 commits into from
Oct 18, 2022

Conversation

AverageMarcus
Copy link
Member

@AverageMarcus AverageMarcus commented Oct 17, 2022

Towards: giantswarm/roadmap#1324

This PR:

  • takes all changes from upstream v1.11.9 Cilium templates and adds them to our app

Testing

Description on how cilium can be tested.

  • fresh install works
    • AWS
    • Azure
    • KVM
  • upgrade from previous version works
    • AWS
    • Azure
    • KVM

Other testing

Description of features to additionally test for cilium installations.

  • check reconciliation of existing resources after upgrading
  • X still works after upgrade
  • Y is installed correctly

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

@AverageMarcus AverageMarcus requested review from a team October 17, 2022 07:02
@AverageMarcus AverageMarcus requested a review from a team as a code owner October 17, 2022 07:02
Signed-off-by: Marcus Noble <[email protected]>
Copy link
Contributor

@whites11 whites11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for what I can tell

@AverageMarcus AverageMarcus merged commit 00c01db into main Oct 18, 2022
@AverageMarcus AverageMarcus deleted the 1.11.9 branch October 18, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants