-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
…rom nodepool handler
service/controller/resource/azuremachinepoolconditions/conditionsubnetready.go
Outdated
Show resolved
Hide resolved
service/controller/resource/azuremachinepoolconditions/conditionsubnetready.go
Outdated
Show resolved
Hide resolved
service/controller/resource/azuremachinepoolconditions/conditionsubnetready.go
Outdated
Show resolved
Hide resolved
service/controller/resource/azuremachinepoolconditions/conditionsubnetready.go
Show resolved
Hide resolved
service/controller/resource/azuremachinepoolconditions/conditionvmssready.go
Outdated
Show resolved
Hide resolved
service/controller/resource/azuremachinepoolconditions/conditionvmssready.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments here and there but it looks great. I was wondering though, why should we care about ARM deployment status? What if we'd focus just on the resources themselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when Jose is happy
We can do that as well, I just went with checking Deployments first, as we use them anyway for deploying things, so we don't use other Azure APIs at all (possible more sensitive to throttling, hey can you blame me 😄) if the deployment is not succeeded first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jose is happy
AzureMachinePool
conditions handlerNew handler for setting following
AzureMachinePool
conditions:SubnetReady
:True
when subnet deployment has been completed successfully, and subnet exists and it hasSucceeded
provisioning state.VMSSReady
:True
when VMSS deployment (nodepool-{id}
) has been completed successfully, and VMSS exists and it hasSucceeded
provisioning state.Ready
:True
whenSubnetReady && VMSSReady
Condition examples
While cluster is being created, so node pool creation has not been started yet:
When the subnet is Ready, but VMSS is still being deployed:
When node pool creation has been completed: