Do not generate a name if Name tag already given so that we can never confuse the values
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
requested changes
Feb 20, 2023
…er confuse the values
AndiDog
force-pushed
the
name-confusion
branch
from
8bd339d
to
17c6e16
Compare
fiunchinho
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same change as applied to CAPA. This way, we don't have 2 distinct values for one semantic meaning, reducing chances to introduce bugs. The related issue giantswarm/roadmap#1866 should already have been solved by #31.
Not tested, since it's a trivial change that we confirmed working in very similar CAPA code.
Checklist
values.yamlandvalues.schema.jsonare valid.