This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
s3-propagate-tags #3177
Merged
s3-propagate-tags #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvix
commented
Sep 29, 2021
| return nil, microerror.Maskf(executionFailedError, "expected 1 CR got %d", len(list.Items)) | ||
| } | ||
|
|
||
| allTags := addCloudTags(tags, list.Items[0].GetLabels()) |
There was a problem hiding this comment.
here we take the usual tags and append the cloud tags to the map
|
thoughts, ideas? |
anvddriesch
approved these changes
Sep 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
poor mans3 bucket tag propagation.The creation of S3 bucket is almost the same we just append the cloud tags from cluster CR
But for the update, we did not have any logic to determine the changes, to make it super simple in each update loop we simply update the tags.
I was thinking about checking if the tags are there before updating but that would be an extra AWS API call and in the end even more expensive than just blindly set the tags to desired value on every loop.
I just wanted to get rid of this ASAP as it's just one customer who needs this.
towards https://github.com/giantswarm/giantswarm/issues/18887