Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Commit

Permalink
Fix Route53 list hosted zones to avoid pagination issue.
Browse files Browse the repository at this point in the history
  • Loading branch information
whites11 committed Jan 31, 2024
1 parent 3717cca commit 73860ac
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fix Route53 list hosted zones to avoid pagination issue.

## [14.24.1] - 2023-12-07

### Changed
Expand Down
4 changes: 2 additions & 2 deletions pkg/project/project.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var (
gitSHA = "n/a"
name string = "aws-operator"
source string = "https://github.com/giantswarm/aws-operator"
version = "14.24.1"
//version = "14.24.1-patch1"
)

func Description() string {
Expand All @@ -25,5 +25,5 @@ func Source() string {
}

func Version() string {
return version
return "14.24.1"
}
5 changes: 4 additions & 1 deletion service/internal/cphostedzone/cphostedzone.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"sync"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/route53"
infrastructurev1alpha3 "github.com/giantswarm/apiextensions/v6/pkg/apis/infrastructure/v1alpha3"
"github.com/giantswarm/microerror"
Expand Down Expand Up @@ -109,7 +110,9 @@ func (h *HostedZone) lookup(ctx context.Context, client Route53, cr infrastructu
// installation. So we look it up.
h.logger.Debugf(ctx, "finding CP HostedZone IDs")

hostedZonesInput := &route53.ListHostedZonesByNameInput{}
hostedZonesInput := &route53.ListHostedZonesByNameInput{
DNSName: aws.String(cr.Spec.Cluster.DNS.Domain),
}

o, err := client.ListHostedZonesByName(hostedZonesInput)
if err != nil {
Expand Down

0 comments on commit 73860ac

Please sign in to comment.