Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golang 1.14.1 #367

Merged
merged 8 commits into from
Apr 2, 2020
Merged

Update to golang 1.14.1 #367

merged 8 commits into from
Apr 2, 2020

Conversation

tfussell
Copy link
Contributor

@tfussell tfussell commented Mar 3, 2020

There are quite a few significant changes in 1.14 including performance improvements, and I think it's best if we don't get too far behind on our versions. We use the latest release of architect in many places so we'll need to do some testing before actually merging this PR. I just wanted to get the conversation started about whether/when we should upgrade.

Build error should be fixed once giantswarm/retagger#384 is merged.

@tfussell tfussell requested review from a team March 3, 2020 18:02
@tfussell tfussell self-assigned this Mar 3, 2020
@MarcelMue
Copy link
Contributor

CI is not happy.

@tfussell
Copy link
Contributor Author

tfussell commented Mar 6, 2020

This is building correctly now that the images have been retagged.

@sslavic
Copy link

sslavic commented Mar 19, 2020

FYI noticed recently a thread on golang-nuts, it seems go 1.14.0 is not usable on mac golang/go#37478
Not sure if we have any devs with mac, they won't be able to update / align local builds with CI tooling. I'm on linux so not affected.

@TheoBrigitte
Copy link
Member

Not sure if we have any devs with mac, they won't be able to update / align local builds with CI tooling. I'm on linux so not affected.

All good here, running macOS and latest go since 10 days.

~ $ go version
go version go1.14 darwin/amd64
~ $ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.14.1
BuildVersion:   18B75

@ghost
Copy link

ghost commented Mar 19, 2020

@TheoBrigitte @sslavic

hi

i confirm with old mac (for me 2009 sierra) go 1.14 don't work

@sslavic
Copy link

sslavic commented Mar 19, 2020

Go 1.14.1 got published few hours ago which has that mac issue fixed.

@ghost
Copy link

ghost commented Mar 19, 2020

Go 1.14.1 a été publié il y a quelques heures et a résolu ce problème de mac.

but i have same probleme with go 1.14.1 & hugo

@tfussell
Copy link
Contributor Author

tfussell commented Mar 20, 2020

I can also confirm that 1.14.0 appears to work fine on my machine with macOS 1.14.6 (MBP 2018). There are some small improvements in 1.14.1, but I think I'll go ahead and merge this unless there are any complaints and we'll bump patch versions as needed.

@kopiczko
Copy link
Contributor

What's the latest here? Should we update to 1.14.1 and merge?

@tfussell
Copy link
Contributor Author

tfussell commented Apr 1, 2020

What's the latest here? Should we update to 1.14.1 and merge?

Sorry, I forgot about this. Now that 1.14.1 is out I think it makes sense to update. Too tired to do it tonight, but I'll take care of it tomorrow unless someone else wants to do it.

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Once this is merged I'll also bump the integration-test job. As I'd like to keep the versions aligned.

https://github.com/giantswarm/architect-orb/blob/71fd006449b5666be2958f0e6fb364e9cb268f25/src/commands/machine-install-go.yaml#L9

@@ -19,7 +19,7 @@ COPY --from=ct /etc/ct/lintconf.yaml /etc/ct/lintconf.yaml
ENV GOPATH /go
ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH

ARG HELM_VERSION=v2.14.3
ARG HELM_VERSION=v2.16.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@tfussell
Copy link
Contributor Author

tfussell commented Apr 2, 2020

Updating retagger again.

@tfussell tfussell changed the title Update to golang 1.14.0 Update to golang 1.14.1 Apr 2, 2020
@tfussell
Copy link
Contributor Author

tfussell commented Apr 2, 2020

Going with this.

@tfussell tfussell merged commit d157575 into master Apr 2, 2020
@tfussell tfussell deleted the update-golang branch April 2, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants