-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to golang 1.14.1 #367
Conversation
CI is not happy. |
This is building correctly now that the images have been retagged. |
FYI noticed recently a thread on golang-nuts, it seems go 1.14.0 is not usable on mac golang/go#37478 |
All good here, running macOS and latest go since 10 days.
|
hi i confirm with old mac (for me 2009 sierra) go 1.14 don't work |
Go 1.14.1 got published few hours ago which has that mac issue fixed. |
but i have same probleme with go 1.14.1 & hugo |
I can also confirm that 1.14.0 appears to work fine on my machine with macOS 1.14.6 (MBP 2018). There are some small improvements in 1.14.1, but I think I'll go ahead and merge this unless there are any complaints and we'll bump patch versions as needed. |
What's the latest here? Should we update to 1.14.1 and merge? |
Sorry, I forgot about this. Now that 1.14.1 is out I think it makes sense to update. Too tired to do it tonight, but I'll take care of it tomorrow unless someone else wants to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once this is merged I'll also bump the integration-test job. As I'd like to keep the versions aligned.
@@ -19,7 +19,7 @@ COPY --from=ct /etc/ct/lintconf.yaml /etc/ct/lintconf.yaml | |||
ENV GOPATH /go | |||
ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH | |||
|
|||
ARG HELM_VERSION=v2.14.3 | |||
ARG HELM_VERSION=v2.16.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Updating retagger again. |
Going with this. |
There are quite a few significant changes in 1.14 including performance improvements, and I think it's best if we don't get too far behind on our versions. We use the latest release of
architect
in many places so we'll need to do some testing before actually merging this PR. I just wanted to get the conversation started about whether/when we should upgrade.Build error should be fixed once giantswarm/retagger#384 is merged.