Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI configuration for pushing to container registries #294

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

marians
Copy link
Member

@marians marians commented Nov 28, 2023

Towards giantswarm/roadmap#2979

This PR was created through automation by Team Honeybadger, to make sure that the container images built for this repository are available in the right registries.

For that, the CircleCI configuration is modified to use the new push-to-registries job instead of the old push-to-docker. This means that there is only one job for all registry pushes, and it simplifies the configuration by removing many parameters that are now set automatically or as defaults.

Notes

  • Since the PR is also changing the CircleCI job name to push-to-registries, the branch protection rules in this repository will likely require updating before the required checks can be green.
  • Dev images are sent to ACR (gsoci.azurecr.io) and Quay currently. If you need dev images elsewhere, you can add the according configuration as described in the documentation to the step configuration.

To the responsible team

Please,

  • Double-check the job dependecies (requires).
  • Double-check the job filters. Especially if this PR replaces several jobs with one, and the previous jobs had different filters, make sure that the filter includes all cases.
  • Update the changelog if you think this deserves a mention.
  • Approve and merge this PR once it's ready. No need to wait for the author in this case.
  • Get this done until 1st of December, so that we can move on with follow-up steps.

@marians marians requested a review from piontec as a code owner November 28, 2023 15:19
@marians
Copy link
Member Author

marians commented Dec 1, 2023

@piontec Can you please take a look here?

Circular job dependency detected: "run-tests" -> "push-to-registries" -> "augment-circleci-dockerfile" -> "push-to-registries"

@marians
Copy link
Member Author

marians commented Dec 5, 2023

@piontec Could you take a look here please?

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e60c73) 74.75% compared to head (aa1c189) 74.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines         721      721           
  Branches      107      107           
=======================================
  Hits          539      539           
  Misses        123      123           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piontec piontec enabled auto-merge (squash) December 6, 2023 12:55
@piontec piontec merged commit e83fc78 into master Dec 6, 2023
6 checks passed
@piontec piontec deleted the circleci-image-registry-configuration branch December 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants