Add networkpool support on AWS Clusters

[paurosello]

Checklist

• Consider SIG UX feedback.
• Update changelog in CHANGELOG.md.
• If adding a new type, ensure that it is added to the CRD unit tests.

[xh3b4sd]

Some thoughts.

• Are there some tests we can extend or add?
• Should we have additional validation?
• How is the optionality of network pools still ensured?

[paurosello]

I created some tests, thanks for reminding 👍

I am checking that setting an empty value for the NetworkPool produces same output as not even specifying the attribute in order to test optionality.

The second test I added is to check that the CR is correctly generated when specifying a NetworkPool

[xh3b4sd]

Just FMI why do we have newAWSClusterExampleCR and NewAWSClusterCR? 🙈

[xh3b4sd]

I see in

apiextensions/pkg/apis/infrastructure/v1alpha2/aws_cluster_types.go

Lines 27 to 37 in 58f996a

	// NewAWSClusterCR returns an AWSCluster Custom Resource.
	func NewAWSClusterCR() *AWSCluster {
	return &AWSCluster{
	ObjectMeta: metav1.ObjectMeta{
	Annotations: map[string]string{
	annotation.Docs: awsClusterDocumentationLink,
	},
	},
	TypeMeta: NewAWSClusterTypeMeta(),
	}
	}

that the spec is empty when using NewAWSClusterCR. /shrug

[paurosello]

yup, not sure about why do we have that empty CR function