This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
add VPC ID to AWSCluster CR #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xh3b4sd
commented
Apr 6, 2020
| @@ -271,6 +272,8 @@ type AWSClusterStatusProvider struct { | |||
| type AWSClusterStatusProviderNetwork struct { | |||
| // IPv4 address block used by the tenant cluster, in CIDR notation. | |||
| CIDR string `json:"cidr" yaml:"cidr"` | |||
| // VPCID contains the ID of the tenant cluster, e.g. vpc-1234567890abcdef0. | |||
| VPCID string `json:"vpcID" yaml:"vpcID"` | |||
There was a problem hiding this comment.
So as discussed with @marians we thought to go with the most simple change which is exposing the VPC ID in the CR status. In aws-operator we would then only need to fill it accordingly. Then customers can read the information from there.
marians
approved these changes
Apr 6, 2020
calvix
approved these changes
Apr 6, 2020
anvddriesch
approved these changes
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/9274.
Checklist