Add pickle support to psutil Exceptions #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add __reduce__ method to exceptions commonly thrown, and start testing that exceptions can be pickled in test_serialization. Fixes giampaolo#2272 Signed-off-by: Anthony Ryan <[email protected]>
|
Nice change. I like it. |
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
Apr 9, 2024
…mpaolo-master * 'master' of https://github.com/giampaolo/psutil: Fix workflow visibility badges in README (giampaolo#2399) OpenBSD: pid_exists() returns True for thread IDs (TIDs) (giampaolo#2395) pid_exists() and Process() disagree on whether a pid exists when ERROR_ACCESS_DENIED (giampaolo#2394) fix ruff errors Fix typos again (giampaolo#2388) fix doc style update HISTORY / CREDITS Include CoreFoundation/CoreFoundation.h (giampaolo#2364) Tests: Compare floats less strictly (giampaolo#2372) chore: build macOS arm64 wheels on macos-14 (giampaolo#2375) Update to fix OSX older version build failure (giampaolo#2379) Makefile: define a PYTHON_ENV_VARS var to use with the $PYTHON var. fix win tests refact serialization tests always use unittest.SkipTest where needed Add pickle support to psutil Exceptions (giampaolo#2380) enable ruff preview mode
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
Apr 9, 2024
* giampaolo-master: Fix workflow visibility badges in README (giampaolo#2399) OpenBSD: pid_exists() returns True for thread IDs (TIDs) (giampaolo#2395) pid_exists() and Process() disagree on whether a pid exists when ERROR_ACCESS_DENIED (giampaolo#2394) fix ruff errors Fix typos again (giampaolo#2388) fix doc style update HISTORY / CREDITS Include CoreFoundation/CoreFoundation.h (giampaolo#2364) Tests: Compare floats less strictly (giampaolo#2372) chore: build macOS arm64 wheels on macos-14 (giampaolo#2375) Update to fix OSX older version build failure (giampaolo#2379) Makefile: define a PYTHON_ENV_VARS var to use with the $PYTHON var. fix win tests refact serialization tests always use unittest.SkipTest where needed Add pickle support to psutil Exceptions (giampaolo#2380) enable ruff preview mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Add
__reduce__method to exceptions commonly thrown, and start testing that exceptions can be pickled in test_serialization.Prior to this, it was not possible to pickle a psutil exception (for error reporting), and this also made it impossible to send them through multiprocessing pipes. Code demonstrating the problem is available in #2272