Properly handle PID type in C #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
added a commit
that referenced
this pull request
Feb 9, 2020
…stems where pid_t size can't be determined at runtime pid_t is an int
giampaolo
added a commit
that referenced
this pull request
Feb 12, 2020
giampaolo
added a commit
that referenced
this pull request
Feb 13, 2020
…if struct.calcsize('l') < 8 assume int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On UNIX, PIDs almost always use
pid_ttype.pid_tmost of the times is anint, but on some systems it may be along long. We never bumped into such a case, but it's good to fix it anyway, and refactor code so that PID is parsed by using a common routine (so that if it's broken we only have one place to fix). By doing so we also standardize allPyArg_ParseTuplecalls which sometimes assumelongand sometimes assumeint(this was the cause of segfault of my Cygwin branch).On Windows, PIDs are almost always
DWORDs, but Python source code usespid_tanyway (it's compatible).Platforms converted in this PR are Linux, FreeBSD and Windows (for the others, I have currently don't have a virtual box image to test against).
This issue affected Python as well:
https://bugs.python.org/issue1983