ValueError bug

[RayOfLight1]

I'm trying to use s-tui and I've recently been unable to start it, the error is:

Traceback (most recent call last):
File "/usr/lib/python-exec/python2.7/s-tui", line 11, in <module>
    load_entry_point('s-tui==0.7.5', 'console_scripts', 's-tui')()
  File "/usr/lib64/python2.7/site-packages/s_tui/s_tui.py", line 854, in main
    graph_controller = GraphController(args)
  File "/usr/lib64/python2.7/site-packages/s_tui/s_tui.py", line 680, in __init__
    self.view = GraphView(self)
  File "/usr/lib64/python2.7/site-packages/s_tui/s_tui.py", line 210, in __init__
    self.temp_sensors_menu = TempSensorsMenu(self.on_sensors_menu_close)
  File "/usr/lib64/python2.7/site-packages/s_tui/TempSensorsMenu.py", line 70, in __init__
    sensors_dict = psutil.sensors_temperatures()
  File "/usr/lib64/python2.7/site-packages/psutil/__init__.py", line 2194, in sensors_temperatures
    rawdict = _psplatform.sensors_temperatures()
  File "/usr/lib64/python2.7/site-packages/psutil/_pslinux.py", line 1150, in sensors_temperatures
    current = float(cat(path)) / 1000.0
ValueError: could not convert string to float:

I have a hwmon module (asus_fan) that reports an empty string for its fan1_input, so a bug in your code (5.4.6) prevents me from starting it:

I have changed just one line in:
/usr/lib64/python2.7/site-packages/psutil/_pslinux.py:1152
from
except (IOError, OSError) as err:
to
except (IOError, OSError,ValueError) as err:

And now it is working apparently fine. Just a heads up

Apparently cat(path) returns a 5 digit value such as 64000 for 64ºC, but this time it had returned an empty string len(cat(path)) is usually 5, but 2 in the crashing return.

[RayOfLight1]

Now I get:

$ sudo s-tui

/usr/lib64/python2.7/site-packages/psutil/_pslinux.py:1160: RuntimeWarning: ignoring ValueError('could not convert string to float: ',) for file '/sys/class/hwmon/hwmon3/temp1_input'
  RuntimeWarning)

$ cat /sys/class/hwmon/hwmon3/temp1_input | hexdump
0000000 0000
0000002

[giampaolo]

please paste the output of “sensors” command

On Sun, 12 Aug 2018 at 14:16, RayOfLight1 ***@***.***> wrote: Now I get: $ sudo s-tui /usr/lib64/python2.7/site-packages/psutil/_pslinux.py:1160: RuntimeWarning: ignoring ValueError('could not convert string to float: ',) for file '/sys/class/hwmon/hwmon3/temp1_input' RuntimeWarning) $ cat /sys/class/hwmon/hwmon3/temp1_input | hexdump 0000000 0000 0000002 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAplLC70MtQWktGajcmLSmmSdB0Z_b5Aks5uQBy5gaJpZM4V5fEk> .

-- Giampaolo - http://grodola.blogspot.com

[RayOfLight1]

% sensors
asus-isa-0000
Adapter: ISA adapter
cpu_fan:       -1 RPM
temp1:        +59.0°C

acpitz-virtual-0
Adapter: Virtual device
temp1:        +59.0°C  (crit = +108.0°C)

asus_fan-isa-0000
Adapter: ISA adapter
CPU Fan:     1894 RPM  (min =   10 RPM, max =  255 RPM)
GFX Fan:     1894 RPM  (min =   10 RPM, max =  255 RPM)
gfx_temp:         N/A  (crit =  +0.1°C)

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +59.0°C  (high = +87.0°C, crit = +105.0°C)
Core 0:        +58.0°C  (high = +87.0°C, crit = +105.0°C)
Core 1:        +56.0°C  (high = +87.0°C, crit = +105.0°C)

% sensors -u
asus-isa-0000
Adapter: ISA adapter
cpu_fan:
  fan1_input: -1.000
temp1:
  temp1_input: 59.000

acpitz-virtual-0
Adapter: Virtual device
temp1:
  temp1_input: 59.000
  temp1_crit: 108.000

asus_fan-isa-0000
Adapter: ISA adapter
CPU Fan:
  fan1_input: 1894.000
  fan1_min: 10.000
  fan1_max: 255.000
GFX Fan:
  fan2_input: 1894.000
  fan2_min: 10.000
  fan2_max: 255.000
gfx_temp:
ERROR: Can't get value of subfeature temp1_input: Can't read
  temp1_crit: 0.105

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:
  temp1_input: 59.000
  temp1_max: 87.000
  temp1_crit: 105.000
  temp1_crit_alarm: 0.000
Core 0:
  temp2_input: 59.000
  temp2_max: 87.000
  temp2_crit: 105.000
  temp2_crit_alarm: 0.000
Core 1:
  temp3_input: 55.000
  temp3_max: 87.000
  temp3_crit: 105.000
  temp3_crit_alarm: 0.000

[giampaolo]

Linux's /sys/class/hwmon really is an unbelievable broken mess.

[RayOfLight1]

I'll try to talk to the module author to sanitize its output, thank you for the commit and commitment ;)