#997 / virtual_memory() / FreeBSD: sysctl vm.stats.vm.v_cache_count f…

…ails on FreeBSD 12; set it to 0
giampaolo · Mar 23, 2017 · 5bb89fd · 5bb89fd
1 parent 33928a6
commit 5bb89fd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -1,5 +1,15 @@
 *Bug tracker at https://github.com/giampaolo/psutil/issues*
 
+*XXXX-XX-XX*
+
+5.2.1
+=====
+
+**Bug fixes**
+
+- 997_: [FreeBSD] virtual_memory() may fail due to missing sysctl parameter on
+  FreeBSD 12.
+
 *2017-03-05*
 
 5.2.0

diff --git a/IDEAS b/IDEAS
@@ -9,8 +9,8 @@ https://github.com/giampaolo/psutil/issues
 PLATFORMS
 =========
 
-- #355 (patch): Android
-- #605 (branch): AIX
+- #355: Android (with patch)
+- #605: AIX (with branch)
 - #276: GNU/Hurd
 - DragonFlyBSD
 - HP-UX

diff --git a/psutil/arch/bsd/freebsd.c b/psutil/arch/bsd/freebsd.c
@@ -468,8 +468,9 @@ psutil_virtual_mem(PyObject *self, PyObject *args) {
         goto error;
     if (sysctlbyname("vm.stats.vm.v_wire_count", &wired, &size, NULL, 0))
         goto error;
+    // https://github.com/giampaolo/psutil/issues/997
     if (sysctlbyname("vm.stats.vm.v_cache_count", &cached, &size, NULL, 0))
-        goto error;
+        cached = 0;
     if (sysctlbyname("vm.stats.vm.v_free_count", &free, &size, NULL, 0))
         goto error;
     if (sysctlbyname("vfs.bufspace", &buffers, &buffers_size, NULL, 0))