Skip to content

Commit

Permalink
fix #927: Popen.__del__ may cause maximum recursion depth error.
Browse files Browse the repository at this point in the history
  • Loading branch information
giampaolo committed Oct 24, 2016
1 parent 82c0876 commit 4708236
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 10 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
*Bug tracker at https://github.com/giampaolo/psutil/issues*


4.4.1 - XXXX-XX-XX
==================

Bug fixes
---------

- 927_: ``Popen.__del__`` may cause maximum recursion depth error.


4.4.0 - 2016-10-23
==================

Expand Down
4 changes: 0 additions & 4 deletions psutil/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1264,10 +1264,6 @@ def __init__(self, *args, **kwargs):
def __dir__(self):
return sorted(set(dir(Popen) + dir(subprocess.Popen)))

def __del__(self, *args, **kwargs):
self.__subproc.__del__(*args, **kwargs)
self.__subproc = None

def __enter__(self):
if hasattr(self.__subproc, '__enter__'):
self.__subproc.__enter__()
Expand Down

0 comments on commit 4708236

Please sign in to comment.