-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove yarn, use npm #5
Conversation
@jmgiaever I have added some |
Ty mate 🫶 Hah, I last night fixed stuff for 9.4.x 😆 I will try to transition for npm tomorrow. It's just burning around me atm. High season at work. Why the change from yarn btw? |
Hi Joachim 🫶 I saw you pushed some stuff recently, feel free to edit the missing pieces here if needed (or tell me what to do, I don't know anything about snap), I would drop the
Long story short is it turned me crazy with bugs on docker, the only way I found to make everything work was to use some mixed npm commands, after making it work I just decided to drop yarn entirely as there was no reason to have both, now image size has been reduced a lot and it also take only 7 minutes to build on all archs compared to 1h 🎉 You can find the full story behind this here: zwave-js/zwave-js-ui#3430 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: check prime on line 178, which excludes npm to be bundled with the snap. This is probably needed now.
@robertsLando is npx needed?
@@ -95,7 +95,7 @@ apps: | |||
restart: | |||
command: bin/restart | |||
|
|||
layout: | |||
layout: # FIXME: npm cache is on `~/.npm` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Means it's a subdirectory of the program files? I might have to do some tricks here, as that might be a Read Only partition.
Do you know if it's possible to specify the cache dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm config set cache /pat/to/cache
or export npm_config_cache=/path/to/cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: is jq and yq needed anymore, elsewhere in the project?
jq is no longer needed, it was to remove yarn dev deps. Dunno about yq it's not needed on my side 🤷🏼♂️ |
I might use them to parse the settings file back and fourth, in the Bourne scripts. Can't recall. I think it's time to rework the project as so much has changed the past years. |
And what about corepack? |
Never used, dunno what is that for? |
No description provided.