fix: draggable grouping shouldn't throw error when dynamically changing columns

[dmitov92]

• get latest reorderedColumns on each end event handler

[dmitov92]

@ghiscoding The columns are getting updated from outside of this function and it often results in "cannot use 'id' of undefined" error as the reorderedColumns instance is getting outdated. If we hide/show columns or we reassign the columns input with a new instance, we are getting this error. Preserving the columns instance doesn't solve all errors.

[ghiscoding]

@dmitov92 how do you update the columns externally? Which functions are you using to do that?
The grid.getColumns() will always return the visible columns only, it's probably what we need here, I can't remember

[codecov]

Codecov Report

Merging #922 (f79d073) into master (da782ed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16605     16604    -1     
  Branches      5906      5906           
=========================================
- Hits         16605     16604    -1     

Impacted Files	Coverage Δ
...es/common/src/extensions/slickDraggableGrouping.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dmitov92]

@ghiscoding We are changing the columns via the angular-slickgrid component (the input), but I don't think it matters how as long as the private columns in the component are updated. You are saving the columns in a let variable, but then we are still able to call setColumns from other functions (inside of Angular-Slickgrid) and when this happens - the let variable doesn't know about the new columns. We should always get all current columns in the beginning of the END event handler just like in this commit or else the let variable will become outdated. In our case, we are changing the columns after the initialization, the columns property of the Angular-Slickgrid gets updated, but the let variable in that function is still holding the old columns.

[ghiscoding]

ok great thanks for the explanation, I was busy with other things but I should be able to test this in the coming days and publish a new release after that. I'm expecting that all done by the end of the week.

[ghiscoding]

@dmitov92 this is now released under Slickgrid-Universal v2.6.2 and Angular-Slickgrid v5.6.1, thanks for the contribution 😃