Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add loading spinner to AutoComplete Editor/Filter #65

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

ghiscoding
Copy link
Owner

  • add SASS styling to use the jQuery UI loading styling (internally jQuery UI will automatically add the CSS class "ui-autocomplete-loading" whenever processing) which shows up after few milliseconds (when using remote calls)

- add SASS styling to use the jQuery UI loading styling (internally jQuery UI will automatically add the CSS class "ui-autocomplete-loading" whenever processing) which shows up after few milliseconds (when using remote calls)
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          193       193           
  Lines        10209     10213    +4     
  Branches      3423      3423           
=========================================
+ Hits         10209     10213    +4     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/autoCompleteFilter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3156cc5...d591de7. Read the comment docs.

@ghiscoding ghiscoding merged commit 4ecd2bd into master Aug 5, 2020
@ghiscoding ghiscoding deleted the feat/autocomplete-styling branch August 5, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants