Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): deleting Slicker object caused issue with cache #635

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

ghiscoding
Copy link
Owner

- previous PR #606 to avoid mem leaks actually create an unintended issue, with Salesforce at least, caching broke because Slicker was no longer exist but the cache think it does.
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #635 (3f3e261) into master (bcb11cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #635   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines        16396     16395    -1     
  Branches      5459      5459           
=========================================
- Hits         16396     16395    -1     
Impacted Files Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb11cd...3f3e261. Read the comment docs.

@ghiscoding ghiscoding merged commit 394c4be into master Feb 8, 2022
@ghiscoding ghiscoding deleted the bugfix/slicker-broken branch February 8, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants