Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reset to previous value when event cancelled, enhances #465 #467

Merged

Conversation

ghiscoding
Copy link
Owner

- this PR enhanced the previous PR #465 and will reset (rollback) the search input value to its previous value when `onBeforeSearchChange` event is prevented, user can optionally cancel that behavior by disabling the flag `resetFilterSearchValueAfterOnBeforeCancellation`
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #467 (6f4ed36) into master (913ef72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #467   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          220       220           
  Lines        13537     13565   +28     
  Branches      4436      4453   +17     
=========================================
+ Hits         13537     13565   +28     
Impacted Files Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/pagination.service.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913ef72...6f4ed36. Read the comment docs.

@ghiscoding ghiscoding merged commit 57e42e5 into master Sep 4, 2021
@ghiscoding ghiscoding deleted the feat/reset-search-value-on-before-search-cancelled branch September 4, 2021 01:09
@ghiscoding ghiscoding changed the title refactor: reset to previous value when event cancelled enhanced #465 refactor: reset to previous value when event cancelled, enhances #465 Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant