Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): IN_CONTAINS should be sanitized when used with html #421

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 26, 2021

  • when using useFormatterOuputToFilter from column params, we need to make sure that it's sanitized without html tags when filtering
  • also remove spaces from the regex check since we want to split only on comma not spaces, the extra spaces are removed by the trim after the split is executed

image

image

- when using `useFormatterOuputToFilter` from column `params`, we need to make sure that it's sanitized without html tags when filtering
- also remove spaces from the regex check since we want to split only on comma not spaces, the extra spaces are removed by the trim after the split is executed
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #421 (961d8fd) into master (3ca8895) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #421   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          219       219           
  Lines        13352     13354    +2     
  Branches      4571      4573    +2     
=========================================
+ Hits         13352     13354    +2     
Impacted Files Coverage Δ
...es/common/src/filter-conditions/filterUtilities.ts 100.00% <100.00%> (ø)
...common/src/formatters/arrayObjectToCsvFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca8895...961d8fd. Read the comment docs.

@ghiscoding ghiscoding requested a review from AnnetteZhang August 9, 2021 12:08
@AnnetteZhang AnnetteZhang merged commit f1cbd52 into master Aug 9, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/in-contains-sanitize-html branch August 9, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants