Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aria): add aria-label to all Editors/Filters & other html templates #413

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

ghiscoding
Copy link
Owner

  • for Editors & Filters we can also provide an optional ariaLabel directly from its definition (e.g.: filter: { ariaLabel: 'Duration Filter', model: Filters.slider })
  • this will help assistive screen reader, it could eventually be enhanced with translated values for now that will do. This is new to me, so I might be wrong in some areas.

- for Editors & Filters we can also provide an optional `ariaLabel` directly from its definition (e.g.: `filter: { ariaLabel: 'Duration Filter', model: Filters.slider }`)
- this will help assistive screen reader, it could eventually be enhanced with translated values for now that will do. This is new to me, so I might be wrong in some areas.
@ghiscoding ghiscoding requested a review from AnnetteZhang July 15, 2021 19:28
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #413 (72471df) into master (502cc0e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #413   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          219       219           
  Lines        13329     13349   +20     
  Branches      4555      4568   +13     
=========================================
+ Hits         13329     13349   +20     
Impacted Files Coverage Δ
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/inputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/inputFilter.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502cc0e...72471df. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit f34a84f into master Jul 15, 2021
@AnnetteZhang AnnetteZhang deleted the feat/aria-label branch July 15, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants