Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): select dropdown value is undefined it shouldn't call save #367

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

ghiscoding
Copy link
Owner

No description provided.

@ghiscoding ghiscoding requested a review from AnnetteZhang June 2, 2021 17:22
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #367 (015294b) into master (bfdc295) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##            master      #367      +/-   ##
============================================
+ Coverage   100.00%   100.00%   +0.01%     
============================================
  Files          213       213              
  Lines        13062     13062              
  Branches      4275      4276       +1     
============================================
+ Hits         13061     13062       +1     
+ Misses           1         0       -1     
Impacted Files Coverage Δ
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
...ges/vanilla-bundle/src/services/resizer.service.ts 100.00% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdc295...015294b. Read the comment docs.

@ghiscoding ghiscoding merged commit 4b979dd into master Jun 2, 2021
@ghiscoding ghiscoding deleted the bugfix/select-editor-undefined-value branch June 2, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants