Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(services): toggle pagination was not displaying all row selection #357

Merged
merged 1 commit into from
May 28, 2021

Conversation

ghiscoding
Copy link
Owner

  • previous PR fix(demo): we should be able to move row(s) and keep selections #352 that fixed row selection with row move actually caused a regression with toggling of pagination, when removing Pagination on the fly it will show all items in the grid and there is code in the Grid State Service that will take row selections from all page and reselect them when we toggle to No Pagination, and we need to change our enablePagination only after that Grid State Service is finished else we end up missing row selection from all other pages

- previous PR #352 that fixed row selection with row move actually caused a regression with toggling of pagination, when removing Pagination on the fly it will show all items in the grid and there is code in the Grid State Service that will take row selections from all page and reselect them when we toggle to No Pagination, and we need to change our `enablePagination` only after that Grid State Service is finished else we end up missing row selection from all other pages
@ghiscoding ghiscoding requested a review from AnnetteZhang May 28, 2021 19:21
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #357 (e51ccb4) into master (95a6635) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        13230     13230           
  Branches      4337      4337           
=========================================
  Hits         13230     13230           
Impacted Files Coverage Δ
packages/common/src/services/pagination.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a6635...e51ccb4. Read the comment docs.

@ghiscoding ghiscoding merged commit 6daec5e into master May 28, 2021
@ghiscoding ghiscoding deleted the bugfix/row-selection-when-removing-pagination branch May 28, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants