Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add Autocomplete/Select Filters collection observers #208

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 21, 2020

TODO

  • add watch collection into AutoComplete & Select Filter
  • add Jest unit tests for both Filters
  • add Cypress E2E tests

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #208 (ae9f003) into master (25392bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       207    +1     
  Lines        11854     11904   +50     
  Branches      3902      3916   +14     
=========================================
+ Hits         11854     11904   +50     
Impacted Files Coverage Δ
packages/common/src/filters/autoCompleteFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/index.ts 100.00% <100.00%> (ø)
packages/common/src/services/observers.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25392bd...ae9f003. Read the comment docs.

@ghiscoding ghiscoding merged commit 3b3b463 into master Dec 21, 2020
@ghiscoding ghiscoding deleted the feat/filter-collection-watch branch December 21, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant