Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vanilla): allow using component w/o grid options #1770

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat(vanilla): allow using component w/o grid options #1770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vanilla-bundle/src/components/slick-vanilla-grid-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class SlickVanillaGridBundle<TData = any> {
protected _darkMode = false;
protected _collectionObservers: Array<null | ({ disconnect: () => void; })> = [];
protected _columnDefinitions?: Column<TData>[];
protected _gridOptions?: GridOption;
protected _gridOptions: GridOption = {};
protected _gridContainerElm!: HTMLElement;
protected _gridParentContainerElm!: HTMLElement;
protected _hideHeaderRowAfterPageLoad = false;
Expand Down Expand Up @@ -216,6 +216,7 @@ export class SlickVanillaGridBundle<TData = any> {
}

set gridOptions(options: GridOption) {
options ??= {} as GridOption;
let mergedOptions: GridOption;

// if we already have grid options, when grid was already initialized, we'll merge with those options
Expand Down
Loading