Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new Slickgrid-Vue package to support VueJS framework #1753

Merged
merged 36 commits into from
Dec 5, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 3, 2024

  • also created a new /frameworks and /demos folders, if that works correctly for this new port, then I'm intending to move all other framework ports in the same folder as well with the next major version (probably around 2025 Q1-Q2). This makes it easier to test, troubleshoot and maintain.

TODOs

  • add new CI Workflow to run Cypress tests separately for Vue
  • update all Vue examples links to point to this new frameworks/demos folders & add Vue to main readme
  • investigate and re-enable skipped ESLint rule for .js extensions everywhere except in Cypress tests where it fails
  • test documentation in monorepo
  • add Readme in Slickgrid-Vue, frameworks and demos folders
  • troubleshoot issue returned by "are the types wrong"
    • once resolved, then probably better to remove CJS build and keep only ESM

Copy link

stackblitz bot commented Dec 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (8efae0e) to head (bc768f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1753   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         187     187           
  Lines       31129   31129           
  Branches     9783    9783           
======================================
  Hits        31040   31040           
  Misses         89      89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title feat: add new Slickgrid-Vue to add VueJS support feat: add new Slickgrid-Vue to support VueJS Dec 3, 2024
@ghiscoding ghiscoding changed the title feat: add new Slickgrid-Vue to support VueJS feat: create new Slickgrid-Vue package to support VueJS framework Dec 3, 2024
@ghiscoding ghiscoding merged commit ec4323b into master Dec 5, 2024
9 checks passed
@ghiscoding ghiscoding deleted the feat/slickgrid-vue branch December 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant