-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new Slickgrid-Vue package to support VueJS framework #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1753 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 187 187
Lines 31129 31129
Branches 9783 9783
======================================
Hits 31040 31040
Misses 89 89 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
feat: add new Slickgrid-Vue to add VueJS support
feat: add new Slickgrid-Vue to support VueJS
Dec 3, 2024
ghiscoding
changed the title
feat: add new Slickgrid-Vue to support VueJS
feat: create new Slickgrid-Vue package to support VueJS framework
Dec 3, 2024
- adding Prettier but only for the new Vue frameworks/demos folders for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/frameworks
and/demos
folders, if that works correctly for this new port, then I'm intending to move all other framework ports in the same folder as well with the nextmajor
version (probably around 2025 Q1-Q2). This makes it easier to test, troubleshoot and maintain.TODOs
.js
extensions everywhere except in Cypress tests where it fails