Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input filter loses focus after edit+filtering with enableExcelCopyBuffer #1750

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 27, 2024

  • some changes made in PR fix: Edit cell mouseout should save & excel copy buffer should still work #917 caused a small issue but only when enableExcelCopyBuffer is set, which only happen after these 2 steps
    1. click on a cell to open an editor
    2. focus on a filter then start typing, the filter will lose focus because it was sent to the grid
  • the issue can be reproduced in Slickgrid-Universal Example 13 (or Angular-Slickgrid Example 3 as shown below)

brave_26DdOI28Gf

Copy link

stackblitz bot commented Nov 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (af9f5db) to head (2ce89f5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1750     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         187     187             
  Lines       31123   31119      -4     
  Branches     9781    9780      -1     
========================================
- Hits        31034   31030      -4     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit b2f4f52 into master Nov 27, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/filter-lose-focus branch November 27, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant