Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor Pagination Component in preparation of Custom Comp #1708

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

ghiscoding
Copy link
Owner

  • refactor the SlickPagination Component and add a basic abstract BasePaginationComponent that will eventually be used by external user to create their own Custom Pagination (future PR)
  • also try to align the constructor with the SlickFooter Component

Copy link

stackblitz bot commented Oct 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (cd6cb96) to head (b750828).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1708     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         187     187             
  Lines       31100   31097      -3     
  Branches     9760    9760             
========================================
- Hits        31011   31008      -3     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 26fa5aa into master Oct 10, 2024
6 checks passed
@ghiscoding ghiscoding deleted the chore/refactor-pagination branch October 10, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant