Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move no pre-parse date warning to vanilla grid comp #1701

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

ghiscoding
Copy link
Owner

  • the previous warning wasn't always showing up when dataset is assigned later (i.e., it wasn't showing in Angular-Slickgrid), we should really move this warning in each framework whenever the dataset is assigned

- the previous warning wasn't always showing up when dataset is assigned later (i.e., it wasn't showing in Angular-Slickgrid), we should really move this warning in each framework whenever the dataset is assigned
Copy link

stackblitz bot commented Sep 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (ea40b74) to head (d448dc5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1701     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       31103   31108      +5     
  Branches     9763    9764      +1     
========================================
+ Hits        31014   31019      +5     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 7f0a446 into master Sep 29, 2024
6 checks passed
@ghiscoding ghiscoding deleted the chore/warn-no-preparse-dates branch September 29, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant