Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add new rowTopOffsetRenderType grid option to use "transform" #1650

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 23, 2024

  • related to this original SlickGrid issue 1044, provide a new grid option to allow the possibility to use top offset CSS style via transform instead of top to fix some UI rendering issue on large dataset
    • for example each .slick-row have a top offset to represent which which row it is, let say our rowHeight is 25px, then the 2nd row typically has a CSS style of top: 50px, the 3rd row has top: 75px, and so on... this new grid option would use transform: translateY(25px) instead, there's benefit in doing this as shown in the article below
  • this might improve perf as well as per this article: Why Moving Elements With Translate() Is Better Than Pos:abs Top/left
  • we could possibly make this the default in our next major release (if it ever happen) but for now we can at least provide it as a new grid option. I also tested this with the Example Grouping (ESM) demo

Copy link

stackblitz bot commented Aug 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (7b01cc2) to head (0cc1070).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1650     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         199     199             
  Lines       21874   21883      +9     
  Branches     7176    7041    -135     
========================================
+ Hits        21811   21820      +9     
- Misses         57      63      +6     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding force-pushed the feat/row-top-offset-style-type branch from 9b162b2 to 3aae589 Compare August 23, 2024 05:23
@ghiscoding ghiscoding merged commit f89a840 into master Aug 24, 2024
7 checks passed
@ghiscoding ghiscoding deleted the feat/row-top-offset-style-type branch August 24, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant