perf: decrease virtual scroll render throttling to 10ms #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ghiscoding
commented
Aug 22, 2024
•
ghiscoding
commented
- see SlickGrid comment for more info
- a lower thottling delay (10ms instead of previously 50ms) will show blank area for a much shorter period whenever we scroll to an uncached scroll position (for example completely scroll to bottom of large grid)
- NOTE: a throttling of 0ms causes flickering and/or other issues in some cases, but 5ms seems like a good number to use
- see SlickGrid [comment](6pac/SlickGrid#219 (comment)) for more info - a lower thottling delay will show less blank area after scrolling to an uncached scroll position (using the scroll to position it very far down) - NOTE: a throttling of 0ms causes flickering in some cases, but 5ms seems like a good number to use
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
=======================================
Coverage 99.8% 99.8%
=======================================
Files 199 199
Lines 21874 21874
Branches 7176 7037 -139
=======================================
Hits 21811 21811
- Misses 57 63 +6
+ Partials 6 0 -6 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.