Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate back to Vanilla-Calendar-Pro #1644

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 17, 2024

  • migrate to vanilla-calendar-pro and drop the custom fork vanilla-calendar-picker (which was always meant to be temporary) that I had created until all features I needed were going to be merged into the original project Vanilla-Calendar-Pro and we are just about to be there.
  • NOTE: the Types are not imported the same way, they must be imported from 'vanilla-calendar-pro/types' instead of the default import

Copy link

stackblitz bot commented Aug 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (14c04d7) to head (8e025e2).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1644    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21849   21849            
  Branches     7306    7023   -283     
=======================================
  Hits        21786   21786            
  Misses         63      63            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding marked this pull request as draft August 17, 2024 20:26
@ghiscoding ghiscoding marked this pull request as ready for review August 21, 2024 16:17
@ghiscoding
Copy link
Owner Author

Vanilla-Calendar-Pro now has all features and fixes that I had in my fork, so we can now officially switch back to that repo.. woohoo 🎉

@ghiscoding ghiscoding merged commit 31fb5c7 into master Aug 21, 2024
9 checks passed
@ghiscoding ghiscoding deleted the feat/switch-vanilla-calendar-pro branch August 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant