Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): header columns grouping misbehave after hiding column #164

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

ghiscoding
Copy link
Owner

  • some header group titles disappear after hiding a column

- some header group titles disappear after hiding a column
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #164 (5587104) into master (ecfb9a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          200       200           
  Lines        11674     11678    +4     
  Branches      3829      3829           
=========================================
+ Hits         11674     11678    +4     
Impacted Files Coverage Δ
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfb9a7...5587104. Read the comment docs.

@ghiscoding ghiscoding merged commit 6b8232b into master Nov 20, 2020
@ghiscoding ghiscoding deleted the bugfix/hide-column-with-header-column-groups branch November 20, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant