Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use Document Fragment in SlickCheckbox for Salesforce Usage #1615

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

good-ghost
Copy link
Contributor

Salesforce does not supoort DocumentDefragment, so add condition preventDocumentFragmentUsage for checkboxSelectorColumn.

Copy link

stackblitz bot commented Jul 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (c03b863) to head (ab6aaff).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1615    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21796   21796            
  Branches     7160    7304   +144     
=======================================
  Hits        21735   21735            
- Misses         55      61     +6     
+ Partials        6       0     -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@good-ghost good-ghost closed this Jul 19, 2024
@ghiscoding
Copy link
Owner

ghiscoding commented Jul 19, 2024

@good-ghost are you having some problems with the creation of a Pull Request? Let me know if you need help, your PR seems correct this time

@ghiscoding ghiscoding reopened this Jul 19, 2024
@ghiscoding
Copy link
Owner

ghiscoding commented Jul 19, 2024

@good-ghost reopening since your Pull Request seems valid to me. Have you tested it in Salesforce? if you want to bundle it and update the zip file for testing, you can run this pnpm command from the root of the project (the zip is located in packages/vanilla-force-bundle/dist-grid-bundle-zip)

pnpm run bundle:zip

EDIT

ahh now I see why you had problem with the PR, I have Husky in place to make sure the PR title follows the Conventional Commit guideline and you were simply missing fix: ... as prefix to the PR title (see Conventional Commit guideline for more info)

@ghiscoding ghiscoding changed the title Add condition preventDocumentFragmentUsage to checkboxSelectorColumn for Salesforce Usage. fix: don't use Document Fragment in SlickCheckbox for Salesforce Usage Jul 19, 2024
@ghiscoding ghiscoding merged commit 5eea8a4 into ghiscoding:master Jul 20, 2024
10 of 12 checks passed
@ghiscoding
Copy link
Owner

ghiscoding commented Jul 20, 2024

@good-ghost I'll go ahead and merge this since I think this is correct now. I'll push a new release today and will update the zip file as well by the end of the day. Thanks for your contribution

EDIT

Released in v5.4.0 and zip file updated. Thanks again for the contribution ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants