Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Select Editor should always close with Escape key #1512

Merged
merged 2 commits into from
May 7, 2024

Conversation

ghiscoding
Copy link
Owner

  • the issue was fixed in upstream lib ms-select-vanilla

- the issue was fixed in upstream lib ms-select-vanilla
Copy link

stackblitz bot commented May 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (2ff15da) to head (f70c2c9).

Additional details and impacted files
@@          Coverage Diff          @@
##            next   #1512   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        198     198           
  Lines      21616   21616           
  Branches    7217    7215    -2     
=====================================
  Hits       21552   21552           
  Misses        58      58           
  Partials       6       6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit e37bb28 into next May 7, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/ms-select-escape branch May 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants