Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name option to CheckboxSelectColumn plugin on columDef #1331

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 15, 2024

  • this will only work when the "Select All" checkbox is NOT shown in the column header titles row (hideInColumnTitleRow: true)

msedge_9E3z18EJQD

- this will only work when the "Select All" checkbox is NOT shown in the column header titles row (`hideInColumnTitleRow: true`)
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1d759f7) 98.2% compared to head (a94d31a) 98.5%.
Report is 2 commits behind head on master.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 87.5% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1331     +/-   ##
========================================
+ Coverage    98.2%   98.5%   +0.3%     
========================================
  Files         198     198             
  Lines       21287   21278      -9     
  Branches     7098    7099      +1     
========================================
+ Hits        20898   20943     +45     
+ Misses        389     335     -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit abe344b into master Jan 15, 2024
4 of 5 checks passed
@ghiscoding ghiscoding deleted the feat/checkbox-select-all-column-title branch January 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants