Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: prefer .forEach over for...in and for...of #1281

Merged
merged 1 commit into from
Dec 22, 2023

perf: prefer `.forEach` over `for...in` and `for...of`

3ce8419
Select commit
Loading
Failed to load commit list.
Merged

perf: prefer .forEach over for...in and for...of #1281

perf: prefer `.forEach` over `for...in` and `for...of`
3ce8419
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 22, 2023 in 0s

88.0% (-0.0%) compared to f6dc75c

View this Pull Request on Codecov

88.0% (-0.0%) compared to f6dc75c

Details

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (f6dc75c) 88.0% compared to head (3ce8419) 88.0%.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 21.3% 37 Missing ⚠️
packages/common/src/core/slickDataview.ts 0.0% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1281     +/-   ##
========================================
- Coverage    88.0%   88.0%   -0.0%     
========================================
  Files         198     198             
  Lines       21350   21361     +11     
  Branches     7099    7109     +10     
========================================
+ Hits        18786   18791      +5     
- Misses       2564    2570      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.