chore: replace all deprecated event keyCode by key string #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's being showing as deprecated for a few years on MDN, they suggest to use `key` instead which is what we'll do
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1208 +/- ##
==========================================
- Coverage 86.08% 86.06% -0.01%
==========================================
Files 209 208 -1
Lines 21271 21239 -32
Branches 7069 7062 -7
==========================================
- Hits 18308 18278 -30
+ Misses 2963 2961 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyinstead which is what we'll do