Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate utils offset of DOM element #1203

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 729 lines in your changes are missing coverage. Please review.

Comparison is base (5e4b14a) 100.00% compared to head (126ace7) 85.66%.
Report is 115 commits behind head on next.

Files Patch % Lines
packages/common/src/core/slickDataview.ts 14.87% 670 Missing ⚠️
packages/common/src/core/slickCore.ts 80.85% 59 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              next    #1203       +/-   ##
============================================
- Coverage   100.00%   85.66%   -14.34%     
============================================
  Files          245      209       -36     
  Lines        16886    21318     +4432     
  Branches      6062     7082     +1020     
============================================
+ Hits         16886    18260     +1374     
- Misses           0     3058     +3058     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 35b2adc into next Nov 21, 2023
3 of 5 checks passed
@ghiscoding ghiscoding deleted the chore/utils-offset branch November 21, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant