Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover jQuery animations in all toggle methods #1196

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 18, 2023

  • remove leftover jQuery slide/fade animations in all toggle methods, use CSS animation instead. We are removing the last animate boolean argument on all methods
    • setTopPanelVisibility
    • setHeaderRowVisibility
    • setColumnHeaderVisibility
    • setFooterRowVisibility
    • setPreHeaderPanelVisibility

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 1104 lines in your changes are missing coverage. Please review.

Comparison is base (5e4b14a) 100.00% compared to head (6748dd3) 78.91%.
Report is 106 commits behind head on next.

Files Patch % Lines
packages/common/src/core/slickDataview.ts 0.39% 784 Missing ⚠️
packages/common/src/core/slickCore.ts 40.83% 200 Missing ⚠️
packages/common/src/core/slickInteractions.ts 3.23% 120 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              next    #1196       +/-   ##
============================================
- Coverage   100.00%   78.91%   -21.09%     
============================================
  Files          245      250        +5     
  Lines        16886    22146     +5260     
  Branches      6062     7233     +1171     
============================================
+ Hits         16886    17475      +589     
- Misses           0     4671     +4671     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 7d6616f into next Nov 18, 2023
3 of 5 checks passed
@ghiscoding ghiscoding deleted the chore/remove-jquery-animation branch November 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant