-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: move SlickGrid core files directly into the project #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1135 +/- ##
============================================
- Coverage 100.00% 78.87% -21.13%
============================================
Files 245 250 +5
Lines 17271 22176 +4905
Branches 6244 7755 +1511
============================================
+ Hits 17271 17488 +217
- Misses 0 4688 +4688 ☔ View full report in Codecov by Sentry. |
5 tasks
* feat(core)!: use new SlickGrid ESM version - use new SlickGrid ESM build - all Cypress E2E tests are now passing - all Jest unit tests are now passing
* chore: test with latest SlickGrid 5.1.0
- drop `slickgrid` npm dependency and instead move all files into the project - the end goal is to have less depencies but also to get rid of unused code like the SlickGrid AutoSize since we have our own code in our ResizerService, this will hopefully make the build smaller as well. There are other duplicate code elsewhere, so moving the code in the project should help simplify the code
ghiscoding
force-pushed
the
feat/move-slickgrid-core-to-internal
branch
from
November 15, 2023 06:05
94f65de
to
f0196c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slickgrid
npm dependency and instead move all files core into the project (mostly because SlickGrid 5.0 is now written in TypeScript, so it is now easier to move into our project and drop external dependency)