You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using Angular with slickgrid-universal and found that according to the following line. It cause all bullet in front of the UL/LI tag in the whole app disappear.
The most painful point is it is not easily overridable, since the selector is at the most global level. My current only work-around is to put more specific selector to other UL/LI, which is is need to do with all other components.
My suggestion is adding more selector or move it into class .slickgrid-container, to make it specific to the slickgrid only.
Reproduction
Simply adding the slickgrid universal stylesheet into your project, and this will happend.
Which Framework are you using?
Angular
Environment Info
| Executable | Version || ------------------- | ------- || (framework used) | VERSION || Slickgrid-Universal | VERSION || TypeScript | VERSION || Browser(s) | VERSION || System OS | VERSION |
oh I see, it seems that my change in this PR was a little too aggressive on the slick.bootstrap.scss file. It could be fixed but only for latest Slickgrid-Universal 2.x and Angular-Slickgrid 5.x, I'm not sure which versions you are since you didn't provide that info above. Feel free to submit a PR if you have time, simply removing this code
should be enough to fix the issue, from that PR #488, it looks like I already have necessary bullet removal on other part of the grid (mainly pagination) that were a problem in the past.
- we shouldn't change any styling that are not explicitely under CSS classes related to Slickgrid since these overrides user's styling which is unexpected and it is also hard for the user to override
Describe the bug
I'm using Angular with slickgrid-universal and found that according to the following line. It cause all bullet in front of the UL/LI tag in the whole app disappear.
https://github.com/ghiscoding/slickgrid-universal/blob/master/packages/common/src/styles/slick-bootstrap.scss#:~:text=ul%20%7B,%7D
The most painful point is it is not easily overridable, since the selector is at the most global level. My current only work-around is to put more specific selector to other UL/LI, which is is need to do with all other components.
My suggestion is adding more selector or move it into class .slickgrid-container, to make it specific to the slickgrid only.
Reproduction
Simply adding the slickgrid universal stylesheet into your project, and this will happend.
Which Framework are you using?
Angular
Environment Info
Validations
The text was updated successfully, but these errors were encountered: