-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker with manual input #1684
Comments
Ah yeah that's probably a decent addition to go with, in Flatpickr we had the
slickgrid-universal/packages/common/src/editors/__tests__/dateEditor.spec.ts Lines 222 to 226 in 11b565e
I think it might be ok to add this as a new option into the VanillaCalendarOption interface, however I think it should stay as disabled or unset by default slickgrid-universal/packages/common/src/interfaces/vanillaCalendarOption.interface.ts Lines 10 to 15 in 3c6ce20
You did use readonly though, should we use the same as Flatpickr or do you still prefer readonly? It might be a good idea to follow the same |
I didnt know about the FlatPickr option but agree that it should be kept as allowEdit and yep it should stay false as default for backwards compat. I'll update the PR with those info |
Clear and concise description of the problem
The new vanilla calender is working great, in combo with copy & paste you're also able to quickly fill out values. Sometimes though, its simply easier to change the date by actually typing it in. Currently slickgrid doesn't provide this feature as the input box is always readonly.
Suggested solution
When a date cell editor is opened, there should be an option to configure readonly mode. If disabled, users can enter dates in the input field and they get synced back to the date control.
Alternative
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: