Skip to content

Commit

Permalink
chore(deps): upgrade to TypeScript 5.5 RC (#1565)
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiscoding authored Jun 10, 2024
1 parent e942539 commit ce0d7c0
Show file tree
Hide file tree
Showing 5 changed files with 100 additions and 100 deletions.
2 changes: 1 addition & 1 deletion examples/vite-demo-vanilla-bundle/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@types/node": "^20.14.2",
"@types/whatwg-fetch": "^0.0.33",
"sass": "^1.77.4",
"typescript": "^5.4.5",
"typescript": "^5.5.1-rc",
"vite": "^5.2.13"
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"sortablejs": "^1.15.2",
"ts-jest": "^29.1.4",
"ts-node": "^10.9.2",
"typescript": "^5.4.5",
"typescript": "^5.5.1-rc",
"typescript-eslint": "^7.12.0",
"whatwg-fetch": "^3.6.20"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/editors/selectEditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export class SelectEditor implements Editor {

// collection of strings, just return the filtered string that are equals
if (this.collection.every(x => typeof x === 'number' || typeof x === 'string')) {
return this.collection.filter(c => selectedValues?.some(val => `${val}` === c?.toString()));
return this.collection.filter((c: SelectOption) => selectedValues?.some(val => `${val}` === c?.toString()));
}

// collection of label/value pair
Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/services/domUtilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function buildMsSelectCollectionList(type: 'editor' | 'filter', collectio
if (Array.isArray(collection)) {
if (collection.every((x: any) => typeof x === 'number' || typeof x === 'string')) {
collection.forEach(option => {
const selectOption: OptionRowData = { text: option, value: option };
const selectOption: OptionRowData = { text: String(option), value: option };
if (type === 'filter' && Array.isArray(searchTerms)) {
selectOption.selected = (searchTerms.findIndex(term => term === option) >= 0); // when filter search term is found then select it in dropdown
}
Expand Down
Loading

0 comments on commit ce0d7c0

Please sign in to comment.